airlift / airbase

Base POM for Airlift
Apache License 2.0
48 stars 87 forks source link

Update maven plugins #253

Closed wendigo closed 3 years ago

wendigo commented 3 years ago

I've tested it by building Trino and running product tests from the build.

Slight change is needed in Trino to make it work:

diff --git a/testing/trino-benchto-benchmarks/pom.xml b/testing/trino-benchto-benchmarks/pom.xml
index 43c4ba195d..6eae23374d 100644
--- a/testing/trino-benchto-benchmarks/pom.xml
+++ b/testing/trino-benchto-benchmarks/pom.xml
@@ -85,7 +85,9 @@
             <plugin>
                 <artifactId>maven-assembly-plugin</artifactId>
                 <configuration>
-                    <descriptor>src/assembly/benchmarks.xml</descriptor>
+                    <descriptors>
+                        <descriptor>src/assembly/benchmarks.xml</descriptor>
+                    </descriptors>
                     <finalName>presto-benchto-benchmarks-package-${project.version}</finalName>
                     <appendAssemblyId>false</appendAssemblyId>
                 </configuration>
(END)
losipiuk commented 3 years ago

This is just housecleaning, right? @electrum PTAL.

wendigo commented 3 years ago

@losipiuk yes, it has a minimal impact on build times (these are lower by a couple of seconds on my machine)