Fix running timezone-sensitive tests in IntelliJ IDEA

[ksobolew]

Some time ago, some properties were moved to argLine because Surefire incorrectly passes the user.language and user.region system properties to the tests. At that time, the user.timezone also got along for the ride, but it turns out, that that latter property is passed correctly. So while it works for Maven and Surefire, moving it into argLine causes IntelliJ IDEA to not pick it up, which in turn means that some tests are not working properly when executed inside the IDE. We can move it safely back, as it improves quality of life.

This reverts parts of commit d4630aa6547a64c7112f2bf133138d7d83b6d1a8.

[findepi]

thanks

update CHANGES too

[ksobolew]

update CHANGES too

Done

[ksobolew]

update CHANGES too

Done

...under the correct version now

[martint]

Can you update the commit message to say “fix xxxx”? You can mention that it’s a partial revert of something else in the commit message, but that’s unnecessary for the title of the commit.

[ksobolew]

Can you update the commit message to say “fix xxxx”? You can mention that it’s a partial revert of something else in the commit message, but that’s unnecessary for the title of the commit.

Sure; done

[findepi]

the new commit title is

Fix passing timezone information to Surefire

which isn't exactly 100% correct.

we were passing timezone information to surefire correctly the fix is for Intellij, afaiu

[ksobolew]

we were passing timezone information to surefire correctly the fix is for Intellij, afaiu

You're right, I changed the title and reworded the commit message a bit too.

[findepi]

Merged, thanks!