search

airlift / airbase

Base POM for Airlift
Apache License 2.0
48 stars 87 forks source link

Update maven-shade-plugin to 3.5.0 #369

Closed ksobolew closed 1 year ago

ksobolew commented 1 year ago

This release, among other things, natively depends on ASM 9.5 with support for new opcodes in Java 21, but we'll keep the ASM version override in case we need a blanket ASM upgrade in the future.

ksobolew commented 1 year ago

cc: @wendigo

ksobolew commented 1 year ago

Though one thing I notice, is that it seems to create dependency-reduced-pom.xml in the module root directory. Not sure if I should treat it as a bug? Shouldn't it be in target/ instead?

wendigo commented 1 year ago

Cc @kokosing

electrum commented 1 year ago

This seems to be the documented behavior. We typically use the following:

<dependencyReducedPomLocation>${project.build.directory}/pom.xml</dependencyReducedPomLocation>
ksobolew commented 1 year ago

This seems to be the documented behavior. We typically use the following:

<dependencyReducedPomLocation>${project.build.directory}/pom.xml</dependencyReducedPomLocation>

Yeah, but somehow this file wasn't actually created before, at least for me. Maybe it was broken in earlier versions 🤷

wendigo commented 1 year ago

Because previously reduced pom was not created. Now it is and it breaks usage of modules that are both executable and libraries like product test launcher in Trino

ksobolew commented 1 year ago

Because previously reduced pom was not created. Now it is and it breaks usage of modules that are both executable and libraries like product test launcher in Trino

OK, is there anything I/we need to fix then?

wendigo commented 1 year ago

It's already configured in Trino where needed so I guess that we are fine