search

airlift / airbase

Base POM for Airlift
Apache License 2.0
48 stars 87 forks source link

Fix javadoc plugin configuration when JDK preview features used #405

Closed findepi closed 6 months ago

findepi commented 6 months ago

cc @electrum @wendigo

findepi commented 6 months ago

relates to https://github.com/airlift/airbase/pull/404

wendigo commented 6 months ago

This still doesn't work in IntelliJ. I think that this is due to the fact that air.compiler.enable-preview is evaluated to produce surefireEnablePreview in the build-helper-maven-plugin which is not something that IntelliJ understands and support.

wendigo commented 6 months ago

I think that instead of air.compiler.enable-preview we should introduce air.compiler.extra-args and pass it directly rather than through bsh-property

findepi commented 6 months ago

This still doesn't work in IntelliJ.

That's not the point of this PR.

This PR fixes building with mvn verify for the case where the Java code relies on features accessible with --enable-preview. Without this, the javadoc processing fails at symbol/class resolution.

wendigo commented 6 months ago

@findepi this would work

findepi commented 6 months ago

updated CHANGES

findepi commented 6 months ago

@electrum would you like to take a look?