search

airlift / airbase

Base POM for Airlift
Apache License 2.0
48 stars 87 forks source link

Disallow class-level warning suppression #411

Open findepi opened 4 months ago

findepi commented 4 months ago

@SuppressWarnings should be applied to narrowest scope possible.

wendigo commented 4 months ago

Did you try that on the Trino?

findepi commented 4 months ago

Did you try that on the Trino?

https://github.com/trinodb/trino/pull/22193

wendigo commented 4 months ago

Sometimes these suppressions are actually needed. In Airlift: 

@SuppressWarnings("checkstyle:TypeName")
    public static class $$RecordedConfigData<T>
findepi commented 4 months ago

I am not convinced this is how we would name a class in 2024.

electrum commented 4 months ago

This seems heavy-handed

findepi commented 4 months ago

I can't disagree.