airlift / airbase

Base POM for Airlift
Apache License 2.0
48 stars 87 forks source link

Remove `InterfaceIsType` checkstyle module #417

Closed Randgalt closed 2 months ago

Randgalt commented 2 months ago

This check prevents a modern Java idiom (and likely future idioms). E.g.

public sealed interface Choice
{
    record GoodChoice(...)
        implements Choice
    {
    }

    record BadChoice(...)
        implements Choice
    {
    }
}

The previous purpose of InterfaceIsType is arguably out of date anyway. It's better to use an interface for utility containers, etc.

wendigo commented 2 months ago

@electrum WDYT? I'm in favor of merging it

wendigo commented 2 months ago

Let's give it a shot.