search

airlift / airbase

Base POM for Airlift
Apache License 2.0
48 stars 88 forks source link

wrong Git tags #460

Open hboutemy opened 3 months ago

hboutemy commented 3 months ago

airbase is marked as successful Reproducible Builds: https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/io/airlift/airbase/README.md

but if you look at buildspecs, you'll see that on each release, I need to manually get the Git commit that was used to do the release to Maven Central, because it's never the commit associated to the Git tag

it would be nice if in future releases, the Git tag was correct, please :)

wendigo commented 2 months ago

This seems to be an issue with our release automation. I’ll investigate it next week

hboutemy commented 1 month ago

@wendigo just a reminder that Git tags are still wrong, I need to adjust manually the commit id on each release

wendigo commented 1 month ago

@hboutemy yes, I'm aware and I have it on my ever-growing to-do list. I'll try to tackle it next week as I need to add similar automation to other projects (trinodb/s3-proxy and gateway to name a few)

wendigo commented 1 month ago

@hboutemy how about now?

wendigo commented 1 month ago

nah, that doesn't work either. I don't get it why the JReleaser is creating improver tag since the HEAD points to the prepare release commit

wendigo commented 1 month ago

This is https://github.com/jreleaser/jreleaser/issues/1692