airlift / aircompressor

A port of Snappy, LZO, LZ4, and Zstandard to Java
Apache License 2.0
566 stars 112 forks source link

.git directory could not be found #84

Closed amerolla closed 6 years ago

amerolla commented 6 years ago

I'm getting this error when I try to build: Failed to execute goal pl.project13.maven:git-commit-id-plugin:2.1.13:revision (default) on project aircompressor: .git directory could not be found! Please specify a valid [dotGitDirectory] in your pom.xml

dain commented 6 years ago

I think you need to build from a full git checkout, which will contain a .git directory.

amerolla commented 6 years ago

Sorry, I accidentally closes this. Thanks Dain. I thought I did that - downloaded the file aircompressor-0.11.tar.gz, extracted, and tried to build. Is there something more I need to do?

dain commented 6 years ago

Clone the repository from github instead of downloading the tar.

amerolla commented 6 years ago

That worked! Thanks Dain.

amerolla commented 6 years ago

Thank you Dain. That did it.

On Tue, Aug 14, 2018 at 2:26 PM, Dain Sundstrom notifications@github.com wrote:

Clone the repository from github instead of downloading the tar.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/airlift/aircompressor/issues/84#issuecomment-412970335, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae4U0iaiA-hiq6Mnrq-BBFu3bL0pso4Sks5uQxZtgaJpZM4V8xip .

amerolla commented 6 years ago

Hey Dain,

Can you point me to any documentation on how to run these benchmarks?

Thanks very much.

On Tue, Aug 14, 2018 at 2:26 PM, Dain Sundstrom notifications@github.com wrote:

Clone the repository from github instead of downloading the tar.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/airlift/aircompressor/issues/84#issuecomment-412970335, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae4U0iaiA-hiq6Mnrq-BBFu3bL0pso4Sks5uQxZtgaJpZM4V8xip .

dain commented 6 years ago

I normally run them from the IDE. @martint do you have the CLI command to run the benchmarks handy?

martint commented 6 years ago

You can run from the CLI like this:

mvn exec:exec -Dexec.classpathScope=test -Dexec.executable="$JAVA_HOME/bin/java" -Dexec.args="-XX:+UseG1GC -cp %classpath io.airlift.compress.benchmark.CompressionBenchmark -p algorithm=airlift_lz4 -i 20 -wi 20 -f 10"

The options after CompressionBenchmark are standard JMH args, so adjust as necessary to control paramenters, warmup/measurement iterations, etc.