search

airlift / airline

Java annotation-based framework for parsing Git like command line structures
Apache License 2.0
846 stars 141 forks source link

Introduction of Java 8, dependency to guava resolved (issue #40) #43

Open Novanic opened 8 years ago

Novanic commented 8 years ago

There is also a fix for a NPE included, see commit ed475f9.

Novanic commented 8 years ago

There is also a refactoring of the "Parser" class included. The class should still be refactored/rewritten in my optinion, because the iterator handling is very confusing and changes can easily result in negative side-effects. The iterator is modified in various methods and depending on a lot of conditions.

Now it should hopyfully a little bit better. The PeekingIterator isn't required anymore, the ParserState and the iterator are lesser modified and therefore the complexity should got reduced, but I could not completely get rid of the confusing iterator handling. Please check this class in detail with the review.

Novanic commented 8 years ago

I think "Travis CI" should execute an mvn clean ("mvn clean install" instead of "mvn install"). Maybe it has problems with the changed Java version. Locally "mvn clean install" is working. All classes can be compiled and all tests run successfully.

electrum commented 8 years ago

Thanks for sending this. It will take some time to review (and the team is quite busy). I merged the NPE bug fix.

spinscale commented 7 years ago

any chance to get this in or is airline considered unmaintained? Should I look for alternatives? I dont wanna be rude, just make an informed decision - I like the library a lot but would love to get rid of guava.