Retain original exception when parsing fails type conversion

airlift / airline

Java annotation-based framework for parsing Git like command line structures

Apache License 2.0

846 stars 141 forks source link

Retain original exception when parsing fails type conversion #68

Closed rtib closed 4 years ago

rtib commented 4 years ago

Fixes #67

rtib commented 4 years ago

As I see, the valueOf and fromString invocations may suffer the same problem, but I haven't tested them yet. I label this as Work-In-Progress for now and update it soon.

rtib commented 4 years ago

Had to struggle a bit with tests, but now it seems complete, squashed and ready for review.

findepi commented 4 years ago

@rtib i realized we don't have checkstyle enabled in airline yet. I posted a PR (https://github.com/airlift/airline/pull/69). You may want to rebase on top.

rtib commented 4 years ago

rebased to #69

findepi commented 4 years ago

@rtib sorry for the delay. We had some internal discussion about https://github.com/airlift/airline/pull/68#discussion_r347576023

Can you please rebase & squash commits? I'll do final pass then

rtib commented 4 years ago

Rebase to what base?

findepi commented 4 years ago

current master. the other PR is merged now.

findepi commented 4 years ago

Merged, thanks!

sorry for the delay, i didn't know you updated the PR

findepi commented 4 years ago

I just released airline 0.9.

@rtib thanks again for your contribution!