search

airlift / airship

Airship is a software deployment and management tool
32 stars 14 forks source link

install --all doesn't work #24

Open aaroncline opened 11 years ago

aaroncline commented 11 years ago

Performing an 'airship install --all' only tries to install the specified software on one server, not all available servers. Doing some packet sniffing it does seem like the Coordinator returns all of the existing servers, but the airship cli must not be handling them correctly.

I have tested this with 3 existing airship agents.

Steps that work for me to reproduce:

  1. Build new environment
  2. Make 3 agent servers
  3. Try to do install --all

My airship cli server is a RHEL 6.x Linux box with the latest JDK from Oracle and I'm running as the root user.

electrum commented 11 years ago

Thanks for the bug report. The --all argument is actually an agent filter, just like --uuid or --host. It is used the same way that the --all slot filter is used for commands like airship start or airship stop. Those commands require a slot filter, so --all is necessary to select everything.

The install command (and the show command) selects all agents by default, so --all is not necessary. We will remove it from all commands that do not need it to avoid confusion.

You can install on multiple agents by specifying a count like --count 50 and it will install on up to that many agents. If the count is lower than the number of matching agents, then it will arbitrarily pick which ones to install onto.