search

airlift / discovery

Discovery Server
54 stars 47 forks source link

Unannounce single service type from node #27

Closed davidhagar-zz closed 10 years ago

davidhagar-zz commented 10 years ago

Previous to this commit a node can announce multiple services at once, but unannounce was limited to removing the node entire. This is problematic when you want to turn off some aspect of a service (possibly for graceful shutdown) while leaving other aspects running.

johngmyers commented 10 years ago

Shouldn't the node just PUT a new announcement omitting those services it wants to turn off?

davidhagar-zz commented 10 years ago

Could do that too, but that feels like a non-obvious use of the API.  On Friday, April 11, 2014 3:31 PM, John Gardiner Myers notifications@github.com wrote:

Shouldn't the node just PUT a new announcement omitting those services it wants to turn off? — Reply to this email directly or view it on GitHub.

davidhagar-zz commented 10 years ago

Though thinking about it, I think I like that better...it's more flexible about shutting down multiple things at once.  On , David Hagar david.hagar@yahoo.com wrote:

Could do that too, but that feels like a non-obvious use of the API.  On Friday, April 11, 2014 3:31 PM, John Gardiner Myers notifications@github.com wrote:

Shouldn't the node just PUT a new announcement omitting those services it wants to turn off? — Reply to this email directly or view it on GitHub.