airlift / discovery

Discovery Server
54 stars 47 forks source link

Fix serialization name in Entry #48

Closed 7c00 closed 2 years ago

7c00 commented 2 years ago

The maxAgeInMs property in Entry class is serialized with the name maxAgeInMs but deserialized as maxAge. That leads to such a problem: in a multiple-node discovery service deployment, an entry sync from other node might never expire as its maxAgeInMs is always null.

7c00 commented 2 years ago

@martint @electrum Thanks for your comments. I have updated the code as the comments. Could you take another reviews? Thanks in advance.

electrum commented 2 years ago

Thanks!