search

airmessage / airmessage-web

AirMessage for the web
https://web.airmessage.org
Apache License 2.0
156 stars 12 forks source link

just prettier #25

Closed Geczy closed 2 years ago

Geczy commented 2 years ago

this PR should just be prettier

the next PR that adds mroe changes is here https://github.com/Geczy/airmessage-web/pull/5

now you can review just formatting changes @tagavari

pnpm is just the pnpm-lock.yaml file that can be safely ignored even if it gets committed. its removed in a subsequent PR.

add ismine to tapback is also removed in the next PR

tagavari commented 2 years ago

Thank you! Sorry to make you go through the trouble of this, I really appreciate that you want to contribute to AirMessage.

I don't think I was clear on my last comment, so let me clarify here. I've used Prettier on some of my other projects, and I agree that it works great. I don't feel comfortable merging a Prettier reformat done by someone else because I can't review that the changes you're submitting are only from Prettier - with over 50k changed lines, it would be difficult for me to tell if a line was inserted anywhere that does something disadvantageous.

Please don't take this as a personal accusation in any way! I'm glad that you're trying to help and I don't see any malicious intent. It's only that AirMessage as a messaging app handles sensitive data, and it would be irresponsible of me to blindly merge this.

I also find that Prettier can really hinder readability, so I'm not entirely sure if I would want to go with it or something else. AirMessage for web doesn't have many people working on it so I'm not too concerned about rigid formatting rules, but I agree that it will become increasingly important and appreciate you bringing it up. I don't have that much time to look into it this week, but I'll let you know when something happens.

For now I'd love to get your other changes merged, so if you could resubmit them as separate PRs, I'd be happy to take a look :)

Geczy commented 2 years ago

you can git revert the prettier all files commit, run prettier --write . yourself, and check that there's no changes in that commit thatll differ from yours (by running git cherry-pick on the same commit hash you reverted)

one quick and easy way to verify its safe

if you dont like the default formatting config i'm submitting, please provide me with one and i'll format my branches to fit your style

thanks