search

airo-ugent / airo-mono

Python packages for robotic manipulation @ IDLab AI & Robotics Lab - UGent - imec
https://airo.ugent.be
MIT License
16 stars 1 forks source link

move from python 3.8-3.10 to 3.10-12 #103

Closed tlpss closed 10 months ago

tlpss commented 10 months ago

3.8 will be EOL in oktober, So I would argue we can move to >=3.10. which we can enforce in the python setup.py

would also need to change tests here: https://github.com/airo-ugent/airo-mono/blob/5cbacd7acee7491435f963e39b33ea29af6b4357/.github/workflows/pytest.yaml#L17

tlpss commented 10 months ago

@Victorlouisdg @adverley anyone has an issue with this proposed change?

tlpss commented 10 months ago

also need to change the conda environment's default python version

Victorlouisdg commented 10 months ago

Sounds good to me, however some packages like ur_rtde only have prebuilt wheels up to 3.11 I believe, making it difficult to install on 3.12.

We should probably also update our types too then, because 3.10 allow tuple instead of Tuple etc.

adverley commented 10 months ago

python >= 3.10 is compatible on my side so no probs for me

On Wed, 3 Jan 2024 at 09:39, Victorlouisdg @.***> wrote:

Sounds good to me, however some packages like ur_rtde https://gitlab.com/sdurobotics/ur_rtde only have prebuilt wheels up to 3.11 I believe, making it difficult to install on 3.12.

We should probably also update our types too then, because 3.10 allow tuple instead of Tuple etc.

— Reply to this email directly, view it on GitHub https://github.com/airo-ugent/airo-mono/issues/103#issuecomment-1875011931, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLT5VFDSAEYEIACLOVI3ATYMUKKZAVCNFSM6AAAAABBKPKWZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVGAYTCOJTGE . You are receiving this because you were mentioned.Message ID: @.***>