search

airpartners / aq-web-client

Web app for end-users.
https://airpartners-ade.web.app/
2 stars 0 forks source link

Add cross-env support #58

Closed anushadatar closed 3 years ago

anushadatar commented 3 years ago

Use the cross-env package to ensure that local app setup runs smoothly on both windows and unix systems without any manual editing on windows or unix-based sytems.

Currently, our start command specified in package.json does not include the set command, so some users on some platforms have to manually add this qualifier. To avoid this asymmetry, we can add the cross-env dependency and build and start using it.

While I perceive that cross-env is a fairly standard addition to this app, it does introduce another dependency we need to manage and update, so that fact is worth considering.

anushadatar commented 3 years ago

Merged branch, will be sure to do a squash and merge when pushing.

anushadatar commented 3 years ago

@hsharriman @davidt315 @Inkering thoughts on this? I can do whatever else testing/confirmation you'd like (or just turn off notifications for this), but would love to tie up this loose end before I graduate...

anushadatar commented 3 years ago

Will of course squash on merge :)

anushadatar commented 3 years ago

Going to merge this so I can be graduated and airpartners PR free