airpartners / logger

Code and documentation associated with the air quality data logger/sensor box.
https://github.com/airpartners/logger/wiki
0 stars 0 forks source link

Add logging to the serialdevices class to facilitate debugging. #11

Open anushadatar opened 3 years ago

anushadatar commented 3 years ago

Mitigate some of the difficulty associated with debug and test by printing statuses, etc. for each step in the connection process if and only if DEBUG has been enabled (maybe use a logging library or something, or even just printing is fine). Test scripts should default to this option.

anushadatar commented 3 years ago

While this fix would be a nice enhancement, I think it should probably be among the lowest priority given timeline for transitioning this project; documentation is a lot more important than nice tooling. Marking as wontfix for now, but if anyone else wants to take it on they can of course.

anushadatar commented 3 years ago

log_and_switch has some logging functionality if you need an example: https://github.com/airpartners/logger/blob/master/log-and-switch.py

anushadatar commented 3 years ago

This should be off by default on the systemd-called implementation, we don't want logs to fill up the disk on the raspi or cause some other problem