search

airpartners / logger

Code and documentation associated with the air quality data logger/sensor box.
https://github.com/airpartners/logger/wiki
0 stars 0 forks source link

Interactive valve test failing to engage even with working valve. #22

Closed anushadatar closed 3 years ago

anushadatar commented 3 years ago

Older versions in tree definitely work as expected, so this issue requires digging back and investigating :)

anushadatar commented 3 years ago

I think this is probably something something BS1010 has the inherited constructor but ThreeWayValve doesn't etc, but I will need ot test it

anushadatar commented 3 years ago

https://github.com/airpartners/logger/blob/d56fd96863f8d6b39593bf6e0e818f3e06685ed4/valvetest.py known stable

anushadatar commented 3 years ago

https://github.com/airpartners/logger/pull/43