log.py and mcpclogger.py are redundant

airpartners / logger

Code and documentation associated with the air quality data logger/sensor box.

https://github.com/airpartners/logger/wiki

0 stars 0 forks source link

log.py and mcpclogger.py are redundant #8

Closed anushadatar closed 3 years ago

anushadatar commented 3 years ago

We can probably delete one of these, but its worth investigating that they both don't need to exist before doing so. Make sure we aren't calling these in unique ways anywhere (especially important to check documentation in the wiki and google drive), make and document a decision.

anushadatar commented 3 years ago

Neither are called within any of the startup scripts, and they both approximately include the same functionality. I searched the wiki and google drive to ensure there were no other mentions that I was missing. With all of that in mind, I think I will go ahead and delete mcpclogger.py - it has some more debugging framework in place, but the mcpc logging test essentially replicates this functionality in a testing context and so I don't think its needed here.

anushadatar commented 3 years ago

See merged pull request - issue closed but tracked in case of future regressions when testing with the full system.