airqo-platform / AirQo-api

This repo contains API definitions for the AirQo platform
MIT License
22 stars 17 forks source link

only returned nearest AirQo sites which are active #3183

Closed Baalmart closed 2 months ago

Baalmart commented 2 months ago

WHAT DOES THIS PR DO?

HOW DO I TEST OUT THIS PR?

WHICH ENDPOINTS SHOULD BE READY FOR TESTING?:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 18.18182% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 30.41%. Comparing base (2abe4d4) to head (82eb9f5).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3183/graphs/tree.svg?width=650&height=150&src=pr&token=HHq3qS3cL6&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform)](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3183?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform) ```diff @@ Coverage Diff @@ ## staging #3183 +/- ## =========================================== - Coverage 30.45% 30.41% -0.04% =========================================== Files 184 184 Lines 24362 24394 +32 Branches 3184 3191 +7 =========================================== + Hits 7419 7420 +1 - Misses 16825 16860 +35 + Partials 118 114 -4 ``` | [Files](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3183?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform) | Coverage Δ | | |---|---|---| | [src/device-registry/utils/create-site.js](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3183?src=pr&el=tree&filepath=src%2Fdevice-registry%2Futils%2Fcreate-site.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform#diff-c3JjL2RldmljZS1yZWdpc3RyeS91dGlscy9jcmVhdGUtc2l0ZS5qcw==) | `33.40% <42.85%> (-0.51%)` | :arrow_down: | | [src/device-registry/models/Site.js](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3183?src=pr&el=tree&filepath=src%2Fdevice-registry%2Fmodels%2FSite.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform#diff-c3JjL2RldmljZS1yZWdpc3RyeS9tb2RlbHMvU2l0ZS5qcw==) | `13.82% <0.00%> (-1.56%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3183/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform)
github-actions[bot] commented 2 months ago

Device registry changes in this PR available for preview here