airqo-platform / AirQo-api

This repo contains API definitions for the AirQo platform
MIT License
22 stars 17 forks source link

fix runtime when sending emails with undefined name #3205

Closed Baalmart closed 2 months ago

Baalmart commented 2 months ago

WHAT DOES THIS PR DO?

HOW DO I TEST OUT THIS PR?

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 30.33%. Comparing base (4dc0019) to head (a21a5ce).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3205/graphs/tree.svg?width=650&height=150&src=pr&token=HHq3qS3cL6&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform)](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform) ```diff @@ Coverage Diff @@ ## staging #3205 +/- ## ======================================== Coverage 30.33% 30.33% ======================================== Files 184 184 Lines 24457 24460 +3 Branches 3200 3200 ======================================== + Hits 7420 7421 +1 - Misses 16923 16925 +2 Partials 114 114 ``` | [Files](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3205?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform) | Coverage Δ | | |---|---|---| | [src/auth-service/config/global/email-templates.js](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3205?src=pr&el=tree&filepath=src%2Fauth-service%2Fconfig%2Fglobal%2Femail-templates.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform#diff-c3JjL2F1dGgtc2VydmljZS9jb25maWcvZ2xvYmFsL2VtYWlsLXRlbXBsYXRlcy5qcw==) | `23.80% <25.00%> (+1.58%)` | :arrow_up: |
github-actions[bot] commented 2 months ago

Auth-service changes in this PR available for preview here