airqo-platform / AirQo-api

This repo contains API definitions for the AirQo platform
MIT License
22 stars 20 forks source link

addressing runtime errors around emailing for 2 jobs #3207

Closed Baalmart closed 4 months ago

Baalmart commented 4 months ago

WHAT DOES THIS PR DO?

HOW DO I TEST OUT THIS PR?

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 30.34%. Comparing base (17fcd94) to head (6d418cf). Report is 1 commits behind head on staging.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3207/graphs/tree.svg?width=650&height=150&src=pr&token=HHq3qS3cL6&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform)](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform) ```diff @@ Coverage Diff @@ ## staging #3207 +/- ## ======================================== Coverage 30.33% 30.34% ======================================== Files 184 184 Lines 24460 24456 -4 Branches 3200 3200 ======================================== Hits 7421 7421 + Misses 16925 16921 -4 Partials 114 114 ``` | [Files](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3207?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform) | Coverage Δ | | |---|---|---| | [src/auth-service/utils/email.msgs.js](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3207?src=pr&el=tree&filepath=src%2Fauth-service%2Futils%2Femail.msgs.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform#diff-c3JjL2F1dGgtc2VydmljZS91dGlscy9lbWFpbC5tc2dzLmpz) | `3.73% <0.00%> (ø)` | | | [src/auth-service/utils/mailer.js](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3207?src=pr&el=tree&filepath=src%2Fauth-service%2Futils%2Fmailer.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform#diff-c3JjL2F1dGgtc2VydmljZS91dGlscy9tYWlsZXIuanM=) | `2.66% <0.00%> (+0.01%)` | :arrow_up: |
github-actions[bot] commented 4 months ago

Auth-service changes in this PR available for preview here