airqo-platform / AirQo-api

This repo contains API definitions for the AirQo platform
MIT License
21 stars 17 forks source link

sends an email alert to User whenever they try to register using already existing email #3218

Closed Baalmart closed 1 month ago

Baalmart commented 1 month ago

WHAT DOES THIS PR DO?

HOW DO I TEST OUT THIS PR?

WHICH ENDPOINTS SHOULD BE READY FOR TESTING?:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 30.30%. Comparing base (ef14821) to head (b4bc373). Report is 6 commits behind head on staging.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3218/graphs/tree.svg?width=650&height=150&src=pr&token=HHq3qS3cL6&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform)](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform) ```diff @@ Coverage Diff @@ ## staging #3218 +/- ## =========================================== - Coverage 30.33% 30.30% -0.04% =========================================== Files 184 184 Lines 24462 24487 +25 Branches 3201 3205 +4 =========================================== Hits 7421 7421 - Misses 16927 16952 +25 Partials 114 114 ``` | [Files](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3218?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform) | Coverage Δ | | |---|---|---| | [src/auth-service/utils/email.msgs.js](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3218?src=pr&el=tree&filepath=src%2Fauth-service%2Futils%2Femail.msgs.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform#diff-c3JjL2F1dGgtc2VydmljZS91dGlscy9lbWFpbC5tc2dzLmpz) | `3.70% <0.00%> (-0.04%)` | :arrow_down: | | [src/auth-service/utils/mailer.js](https://app.codecov.io/gh/airqo-platform/AirQo-api/pull/3218?src=pr&el=tree&filepath=src%2Fauth-service%2Futils%2Fmailer.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=airqo-platform#diff-c3JjL2F1dGgtc2VydmljZS91dGlscy9tYWlsZXIuanM=) | `2.56% <0.00%> (-0.10%)` | :arrow_down: |
github-actions[bot] commented 1 month ago

Auth-service changes in this PR available for preview here

github-actions[bot] commented 1 month ago

Auth-service changes in this PR available for preview here

luigimorel commented 1 month ago

I apologize if this comes off as offensive.

I believe there is no need to notify the other user if someone else tries to register using the email associated with their account.

I can only imagine the panic that the already existing users will experience whenever they get this message

You already exist as an AirQo User.

each time another user tries to, say has a typo in the email they're trying to register with.

Preferred way Doing registration, .

I could be wrong though since I do not have access to internal discussions and the fullpicture.