search

airr-community / airr-standards

AIRR Community Data Standards
https://docs.airr-community.org
Creative Commons Attribution 4.0 International
35 stars 23 forks source link

top-level DataProcessing would require a different uniqueness level for data_processing_id #454

Open schristley opened 4 years ago

schristley commented 4 years ago

The current DataProcessing object is a sub-object within Repertoire so it's data_processing_id only needs to be unique within a repertoire. If we want to make DataProcessing a top-level object, or at least generalize it beyond Repertoire so that it can describe operations on RepertoireSet, Clone and etc., then it's uniqueness level should change so that the id can be used across multiple objects.

bcorrie commented 9 months ago

I am thinking that changing this is not really necessary for v2.0 - unless it is necessary for the RepertoireGroup and Manifest objects. @schristley thoughts?

schristley commented 9 months ago

I am thinking that changing this is not really necessary for v2.0 - unless it is necessary for the RepertoireGroup and Manifest objects. @schristley thoughts?

Not necessary for v2.0 as we won't be re-designing DataProcessing for v2.0. Still an issue to be considered so I've moved forward to v2.1