search

airr-community / airr-standards

AIRR Community Data Standards
https://docs.airr-community.org
Creative Commons Attribution 4.0 International
35 stars 23 forks source link

characterize the custom schema attributes in OGRDB #518

Closed schristley closed 3 years ago

schristley commented 3 years ago

Decide which can/should be made part of x-airr.

williamdlees commented 3 years ago

In 517 you are asking which objects in the OGRDB schema are relevant to a germline gene reference set. Here I think you must be asking what other objects in the OGRDB schema should go into the x-airr schema. I don't think there are any.

schristley commented 3 years ago

Not objects per se, but additional attributes on the objects and/or properties. From a quick skim of the schema, I see occurrence, rows, width. Maybe they are not needed and can be removed. The type of many of the properties will need to be cleaned up too.

williamdlees commented 3 years ago

I thought I'd rmoved all the row and width attributes: they are gone now. The preamble (discriminator, type, occurrence) was modelled on the AIRR schema at the time this one was first put together, it can be updated to whatever is used now. The types, I think, are best updated when we complete a review of the content of the schema, because they contain useful information that will need to be documented elsewhere, should we choose to keep the attributes.

schristley commented 3 years ago

Hi @williamdlees , created this issue in case there were OGRDB specific attributes that you might want in the schema as optional attributes. I think you indicated there probably won't need to be any? If you still believe so then we can close this issue.

williamdlees commented 3 years ago

Thanks, I think we should close this now.