Closed bcorrie closed 3 years ago
Yes it should be label in both cases. Do I fix this in the germline branch and make a pull request, or does it need a new branch?
On 22 Sep 2021, at 20:35, Brian Corrie @.***> wrote:
I notice that
documented_alleles used to have gene_symbol and now it has label. undocumented_genes has gene_symbol @williamdlees it looks like you made the change in documented_alleles, should this be consistent with undocumented_genes
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.
Yes it should be label in both cases. Do I fix this in the germline branch and make a pull request, or does it need a new branch?
@williamdlees It's best to create a new branch from master with a new PR; that usually makes it easier to review and merge. I generally name the branch with the issue, i.e. issue-554
. You can probably use the germline branch but you need to make sure that you bring it up to date with master, but then you still need to create a PR so it can be merged. I forget if github re-opens the old PR or makes a new one.
I notice that
documented_alleles
used to havegene_symbol
and now it haslabel
.undocumented_genes
hasgene_symbol
@williamdlees it looks like you made the change in
documented_alleles
, should this be consistent withundocumented_genes
https://github.com/airr-community/airr-standards/blame/8e07bd75736c3c32e926f08b6042709940794ded/specs/airr-schema.yaml#L975