Closed bcorrie closed 2 years ago
@schristley do you want to have a look at this? Basic sections for new API entry points now exist.
Enabled branch on RTD.
CellExpression
schema has title of Cell
instead.airr/v1/expression/{expression_id}
is in the API spec?CellExpression
schema seems to be missing from the AIRR Data Model with the other schemas.Otherwise looks good.
@schristley
Receptor schema link is not active.
It will be introduced via #404, so it should be fine as long as we merge both of them soon.
- The
CellExpression
schema has title ofCell
instead.
@schristley I can't find where this occurs???
- Doesn't look like
airr/v1/expression/{expression_id}
is in the API spec?
Nice catch, fixed.
- The
CellExpression
schema has title ofCell
instead.@schristley I can't find where this occurs???
From the endpoints table, there is a link to the CellExpression schema
CellExpression
schema seems to be missing from the AIRR Data Model with the other schemas.
Sorry - not clear what is missing here. Is this in the docs or in the actual schema?
In the docs, https://docs.airr-community.org/en/adc-docs/datarep/overview.html
Fixed, thanks. @schristley @bussec @javh can you take a look at the wording I used here. Not sure my one sentence description of these objects are going to be correct. In particular, I am not sure how to describe Receptor
or Clone
correctly.
Need to update conf.py
and stick in the bit of code to insert the schema table.
So are the schemas that we are adding for v1.4 really still "Experimental" as per the above Docs pages? How do they become not "Experimental" if not through an official release?
I am not sure how the conf.py works and what pages it generates. Can someone enlighten me - or if it is easy make the changes.
OK, I think I have it... If anyone wants to make any changes to the overview page and the high level description of these objects, let me know. Otherwise I will merge later today...
In the docs, https://docs.airr-community.org/en/adc-docs/datarep/overview.html
Fixed, thanks. @schristley @bussec @javh can you take a look at the wording I used here. Not sure my one sentence description of these objects are going to be correct. In particular, I am not sure how to describe
Receptor
orClone
correctly.
So are the schemas that we are adding for v1.4 really still "Experimental" as per the above Docs pages? How do they become not "Experimental" if not through an official release?
Yeah, they are still experimental. It's fuzzy, but they exit "Experimental" when they become stable. Ie, we stop messing with them except for minor updates, we start caring about breaking backwards compatibility, they are well tested, etc.
They enter "Experimental" when we put them in a release and make them available to the public to experiment with. "Experimental" status is a disclaimer that while schema is a usable draft, it isn't stable.
So are the schemas that we are adding for v1.4 really still "Experimental" as per the above Docs pages? How do they become not "Experimental" if not through an official release?
Yeah, they are still experimental. It's fuzzy, but they exit "Experimental" when they become stable. Ie, we stop messing with them except for minor updates, we start caring about breaking backwards compatibility, they are well tested, etc.
They enter "Experimental" when we put them in a release and make them available to the public to experiment with. "Experimental" status is a disclaimer that the schema isn't stable.
OK, gotcha... So a goal would probably be to have all of our current "Experimental" schemas/apis as non-Experimental for the 2.0 release.
Closes #605
Ideally, yeah, they are experimental for a release then they become production ready in the next release. But, that doesn't happen often in practice. Alignment
is still experimental and probably always will be, because there doesn't seem to be much of a use case, so there's no point in finalizing it and no real way to test it if we did.
@bcorrie LGTM, do you want to merge this before or after I merge #404?
Sounds like less work for me if I merge first 8-)
I will pull the trigger now...
Closes #597 #605