is this a violation of our naming policy?

airr-community / airr-standards

AIRR Community Data Standards

https://docs.airr-community.org

Creative Commons Attribution 4.0 International

35 stars 23 forks source link

is this a violation of our naming policy? #638

Closed schristley closed 1 year ago

schristley commented 2 years ago

I was looking at a GermlineSet and saw this. I thought our policy was lower snake case? Are we making exceptions for proper names (or stuff like ORCID)?

I kinda wonder why this isn't a CURIE, isn't it an external identifier?

          "acknowledgements": [
            {
              "acknowledgement_id": "",
              "name": null,
              "institution_name": null,
              "ORCID_id": null
            }
          ],

javh commented 2 years ago

Not that I know of (and wouldn't want to). I think it's just a typo.

Edit: ^ regarding the case. Yes, this seems like it should be a CURIE, but I didn't make that change in #639.

bussec commented 2 years ago

I agree that it should be lower snake case, therefore #639 is fine with me. I also think that this should become a CURIE, as we now have support for ORCID in the CURIE section of the Schema. This can be addressed via #552 for v2.0.