airr-community / airr-standards

AIRR Community Data Standards
https://docs.airr-community.org
Creative Commons Attribution 4.0 International
35 stars 23 forks source link

`discriminator` keyword is being used improperly in the schema #686

Closed schristley closed 1 year ago

schristley commented 1 year ago

I discovered this when using a JSON validator. We have a discriminator keyword on all of our objects, however its usage is not correct. It's meant to be used with oneOf where the propertyName in the discriminator indicates what property can be used to distinguish the appropriate object in the oneOf union.

Because we aren't using oneOf anywhere, we should essentially delete all of the discriminators.

schristley commented 1 year ago

@javh This is an easy fix, I can add to #674 if you agree.

javh commented 1 year ago

@schristley, works for me to add it to #674. Thanks!