search

airr-community / airr-standards

AIRR Community Data Standards
https://docs.airr-community.org
Creative Commons Attribution 4.0 International
35 stars 23 forks source link

Why are dependencies not getting installed on when on readthedocs? #692

Closed grst closed 1 year ago

grst commented 1 year ago

Hi,

what's the reason for this check to exist? https://github.com/airr-community/airr-standards/blob/2520bbd28d0a9696a24efe7a05a91d73482546e2/lang/python/setup.py#L17-L19

The issue I have with that is that it does not only affect the airr package itself on readthedocs, but also all packages that depend on it (in my case scirpy). I wasted an entire evening figuring out why my documentation builds in a clean environment locally, but not on readthedocs -- it turned out that, well, dependencies were missing.

Cheers, Gregor

javh commented 1 year ago

It's a workaround for ReadTheDocs not allowing installation of packages requiring C compilation in virtual environments. Ie, bypassing attempts to install dependencies like numpy that would cause the build to fail.

That's the reason it exists anyway... I suspect this is no longer necessary as binaries should be available on pypi for all this stuff now. It has been many years. Let me test.