search

airr-community / airr-standards

AIRR Community Data Standards
https://docs.airr-community.org
Creative Commons Attribution 4.0 International
35 stars 23 forks source link

add null enum for nullable fields #708

Closed schristley closed 11 months ago

schristley commented 11 months ago

fixes #697

Also fixes a few fields in V2 spec missing nullable flag

bussec commented 11 months ago

@schristley Properties that are x-airr.miairr = essential are by definition not nullable.

schristley commented 11 months ago

@bussec I was wondering about that, why fields were marked essential but had nullable: true. Are the miairr tags on the germline fields correct and I can fix their nullable state, or are they still being debated?

schristley commented 11 months ago

@bussec I'll fix the schema in a separate PR so it can merged for 1.5 and add some additional consistency checks as it seems a few things are being missed, and the two schema versions are getting increasingly out of sync and/or inconsistent.

schristley commented 11 months ago

removed null for essential fields