search

airr-community / airr-standards

AIRR Community Data Standards
https://docs.airr-community.org
Creative Commons Attribution 4.0 International
35 stars 23 forks source link

Property type redo #719

Closed bcorrie closed 10 months ago

bcorrie commented 11 months ago

Redo of property_type fixes, with just property_type field but adding detection keywords to suggested strings.

bcorrie commented 11 months ago

Changes as I think we discussed, @bussec I added three possible values, the three former types with a detection method of count, which is I think applicable for our use case. Can you add some other possibilities (and correct mine if in error).

I have the following: "gene_expression_count", "surface_protein_expression_count", "antigen_specific_receptor_expression_count".

scharch commented 10 months ago

@javh it's a nit, but all 3 are UMIs. Also, I'm not crazy about calling them "barcodes" instead of just surface_protein or something. But I don't care enough to make an issue of it if others feel differently.

bussec commented 10 months ago

I now added "fluorescence_intensity" as the measured parameter and added _by_ as a human-readable separator between the property type and the detection method.

javh commented 10 months ago

@scharch I agree with you. But, I we decided to make the field a combination of readout and method.

@bussec I'm good with those changes.