search

airr-community / airr-standards

AIRR Community Data Standards
https://docs.airr-community.org
Creative Commons Attribution 4.0 International
35 stars 23 forks source link

Issue 723: Add MiAIRR compliance flag #724

Closed jday1 closed 4 months ago

jday1 commented 10 months ago

This PR implements the first step for https://github.com/airr-community/airr-standards/issues/723.

A further benefit of this PR is that it fully aligns SyntenyBio's fork with airr-community which will allow us to the airr package directly in the future. This has been ongoing work at Synteny for several months and with this merge and release it will allow us to more actively contribute to AIRR.

javh commented 10 months ago

Thanks! Given that we are in feature freeze to get the v1.5 release out, this might not make it into v1.5. I'll take a closer look to be sure.

If not, there will be a lot of merges after the release and we can work this into that.

javh commented 8 months ago

From the call:

scharch commented 7 months ago
  • Check if this is the best implementation approach. Eg, instead change the behavior of validate to multiple levels (none, miairr, strict, whatever).

@jday1 can you please explain to me why the check_miairr_compliant variable is passed to the validation function instead of being used to just skip the validation function if false? I feel like I'm missing something...

jday1 commented 4 months ago

I realised this was a duplicate of https://github.com/airr-community/airr-standards/pull/750. I've closed this PR in favour of the other as we have made more progress on that.