Is linked_subjects in Subject for single or multiple subject links?

airr-community / airr-standards

AIRR Community Data Standards

https://docs.airr-community.org

Creative Commons Attribution 4.0 International

35 stars 23 forks source link

Is linked_subjects in Subject for single or multiple subject links? #728

Open schristley opened 9 months ago

schristley commented 9 months ago

The field name as plural suggests multiple, but the description is written as though single. Also the fact that it's a single text field suggests single. Though it seems like supporting multiple would be desirable, like linking both mother and father for genealogy. If the intent is multiple then I'd suggesting using the flexibility of JSON schema and make it an array of objects where each object contains the subject id and link type.

bussec commented 9 months ago

+1 for an array of objects. Does anyone have a good ontology for link_type terms? Should include both genetic as well as exposure relationships. I had a look at OBO, but could not find anything suitable...

schristley commented 9 months ago

I did find the FHHO but it does not have exposure relationships.

bussec commented 9 months ago

Did some more digging, and SNOMED CT has a rather comprehensive set of relations. If there wouldn't the issue that it is not available under an open license...

bcorrie commented 5 months ago

v2.0 consideration? I have added it for now - seems like a small change other than sorting out the relationship question.