Allow missing values in logical fields when validating tabular data

airr-community / airr-standards

AIRR Community Data Standards

https://docs.airr-community.org

Creative Commons Attribution 4.0 International

35 stars 23 forks source link

Allow missing values in logical fields when validating tabular data #731

Closed kelliemac closed 3 months ago

kelliemac commented 8 months ago

This is regarding the R package.

Currently, when I use airr::read_rearrangement() I will get warnings like "Warning: vj_in_frame is not logical for row(s): ..." when the only values in that column are TRUE, FALSE, and NA. This stems from the fact that checks on the logical fields currently only allow TRUE and FALSE, not NA. I think that NA should be a valid value in a logical field.

javh commented 3 months ago

Thanks for submitting this PR @kelliemac. I'm sorry this one slipped through the cracks. This looks good to me.

kelliemac commented 3 months ago

Thank you @javh ! I'm happy that this package exists and glad to be able to contribute in a small way.