search

airr-community / airr-standards

AIRR Community Data Standards
https://docs.airr-community.org
Creative Commons Attribution 4.0 International
35 stars 23 forks source link

Change pub_ids to be array of CURIEs #746

Closed bcorrie closed 4 months ago

bcorrie commented 4 months ago

closes #740

bcorrie commented 4 months ago

Fixes have been made, @bussec do you want to review?

bussec commented 4 months ago

@bcorrie Looks good to me in general, two points regarding consistency:

  1. Could we used bracket notation [ foo, bar ] for the YAMLs, instead of the single lines?
  2. Could we use the same two identifiers throughout the schema?
bcorrie commented 4 months ago

I have used relevant IDs in the schema - since there are two different pub_ids fields, one in Study and one in Germline it doesn't make sense to have the same example PMID.

Other changes made... does that work?