search

airr-community / airr-standards

AIRR Community Data Standards
https://docs.airr-community.org
Creative Commons Attribution 4.0 International
35 stars 23 forks source link

RepertoireGroup updates for v2.0, take two #773

Open scharch opened 4 months ago

scharch commented 4 months ago

Replaces #748 Closes #578

So far: just some docs updates...

scharch commented 1 month ago

I went very simple with the filters and just linked the docs page to what you have written for the API. If it looks ok, I will copy to the other files.

schristley commented 1 month ago

@scharch Are the filters only suppose to apply to rearrangements? Or are you expecting that it can be specified using a typed-key like in the example?

scharch commented 1 month ago

@scharch Are the filters only suppose to apply to rearrangements? Or are you expecting that it can be specified using a typed-key like in the example?

The latter. Does that need to be in the schema explicitly?

schristley commented 1 month ago

@scharch Are the filters only suppose to apply to rearrangements? Or are you expecting that it can be specified using a typed-key like in the example?

The latter. Does that need to be in the schema explicitly?

It doesn't need to be but I think it would make it more clear, as it's not obvious that should be done based upon the doc blurb. It would also make it more explicit what AIRR objects can be filtered. Thinking about it, using Repertoire: seems reasonable at the group level, but then that conflicts with the repertoires array...