airr-community / airr-standards

AIRR Community Data Standards
https://docs.airr-community.org
Creative Commons Attribution 4.0 International
35 stars 23 forks source link

Add consistency checks to make sure unit test data are identical between R and python #775

Open javh opened 4 months ago

javh commented 4 months ago

The unit test data sets seems to have gotten out of sync:

schristley commented 4 months ago

@javh this is what I was referring to here. I was trying to make the test data identical and saw differences. The R version is using NA which causes python to puke. The python version was okay for R except it fails because the R test is checking specific values, that could presumably be fixed by updating the checks in the R test.

schristley commented 4 months ago
  • Should we add consistency checks to GitHub Actions to avoid this in the future?

PR #767 has those consistency checks.

javh commented 4 months ago

Ahhh... Thanks, @schristley. If we swap the NA for an empty string then that should work.