Closed bcorrie closed 4 years ago
It appears to me that Recommendation 8 and 9 should be reviewed...
There also appears to be a gap in what I would consider as our main goal of this year - defining an API that makes it possible to perform consistent queries across AIRR compliant repositories.
Right, of course the whole recommendations documented will need to be updated to reflect this work.
My two cents on the current version:
Christian and everyone, see my inline comments below in blue. Thanks!
- Rec. 10: PII and PHI are - best to my knowledge - US legal terms. We should use more generic wording that also captures European GDPR.
Do you happen to know what the terms are?
Rec. 13: We should make sure that IEDB can capture the all metadata required by MiAIRR, otherwise this recommendation should be rephrased and recommend deposition at IEDB as a secondary submission (cross-referencing to and cross-referenced by the primary repository.
Bjoern was heavily involved in the writing of the recommendations, including this particular recommendation, so I think it is safe to assume that they are making IEDB MiAIRR compliant.
Rec. 14: Do we still have any contact at ImmPort? What is the level of implementation there?
My most recent communications with ImmPort were in September 2018. I can reach out again to confirm, but they were very happy to do this. They do not want to deal with sequencing data directly.
It appears to me that Recommendation 8 and 9 should be reviewed...
@laserson would you be able to have a look at Recommendation 8 here: https://github.com/airr-community/common-repo-wg/blob/issue-27/recommendations.md
I have removed mention of Avro, Thrift, and Protocol Buffers and left in the generic text. Our recollection was that you had suggested these originally.
lgtm
@lgcowell, I did more reading regarding Rec. 10 and we should probably have someone with a legal background go over this:
- Rec. 10: PII and PHI are - best to my knowledge - US legal terms. We should use more generic wording that also captures European GDPR.
Do you happen to know what the terms are?
Wasn't this cleaned up and ratified at the last AIRR Community meeting, so we can close?
Yes, I believe so...
Closing...
It is probably time to review these as we approach the May meeting.
I have created a branch that we can use to make changes...
https://github.com/airr-community/common-repo-wg/blob/issue-27/recommendations.md