airr-knowledge / issues

Issues and project management for the AKC
0 stars 0 forks source link

Generate/document list of ontologies being used by each repository #6

Closed bcorrie closed 7 months ago

bcorrie commented 8 months ago
bcorrie commented 8 months ago

I added a column in the Consolidated Fields that pulls out whether the AIRR Spec or IEDB treats a field as an ontology field and if so what ontology is used and if both AIRR and IEDB think it is an ontology whether the ontologies used are the same.

Good news is that when both use ontologies, they appear to use the same ontology - yeah us 8-)

bcorrie commented 8 months ago

There are a couple of "Filter Views" in the spreadsheet that filter data based on ontology status in various forms.

bcorrie commented 7 months ago

In Consolidate Field Mapping.xlsx there is an Ontology column. It is populated currently for AIRR (Column AI) and IEDB (Column O) Ontology columns. I created VDJBase (Column F) and IRAD (Column I) ontology columns.

@bpeters42 @rvita do you consider Column O to be complete for IEDB? If so do you want to check the above box in the list.

@williamdlees similarly, for VDJBase can you look at Column F and check the ontology fields and if you feel they are up to date then check the list above for VDJBase and confirm that any fields that use ontologies are noted along with which ontologies. I suspect you map pretty closely (if not exactly) to the AIRR ontology terms. If so then you are done 8-)

@krishnaroskin @KevinABurns137 can you do the same for column I and confirm that any fields that use ontologies are noted along with which ontologies that are used.

I think this should be quick (???) and if so we can then close this issue.

bcorrie commented 7 months ago

@KevinABurns137 @krishnaroskin I see that you have already checked the box - thanks.

bpeters42 commented 7 months ago

I checked the IEDB box - as I think the spirit of this is done. We might want to consider if we also want to capture non-ontology references to databases (e.g. Pubmed, UniProt), that have similar function. And I noted that some fields are missing from the alignment for the IEDB, e.g. 'process type' under 'in vivo process' - presumably because they only make sense in combination with other fields (Immunogen), which is aligned. I suspect/hope this will make much more sense when we do the field alignment within.

williamdlees commented 7 months ago

Confirmed that VDJbase uses the same ontologies as MiAIRR and no others.

William

From: Brian Corrie @.> Sent: Wednesday, November 8, 2023 7:43 PM To: airr-knowledge/issues @.> Cc: William Lees @.>; Mention @.> Subject: Re: [airr-knowledge/issues] Generate/document list of ontologies being used by each repository (Issue #6)

In Consolidate Field Mapping.xlsx there is an Ontology column. It is populated currently for AIRR (Column AI) and IEDB (Column O) Ontology columns. I created VDJBase (Column F) and IRAD (Column I) ontology columns.

@bpeters42 https://github.com/bpeters42 @rvita https://github.com/rvita do you consider Column O to be complete for IEDB? If so do you want to check the above box in the list.

@williamdlees https://github.com/williamdlees similarly, for VDJBase can you look at Column F and check the ontology fields and if you feel they are up to date then check the list above for VDJBase and confirm that any fields that use ontologies are noted along with which ontologies. I suspect you map pretty closely (if not exactly) to the AIRR ontology terms. If so then you are done 8-)

@krishnaroskin https://github.com/krishnaroskin @KevinABurns137 https://github.com/KevinABurns137 can you do the same for column I and confirm that any fields that use ontologies are noted along with which ontologies that are used.

I think this should be quick (???) and if so we can then close this issue.

— Reply to this email directly, view it on GitHub https://github.com/airr-knowledge/issues/issues/6#issuecomment-1802538975 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXBI7JQO7J4Q6FMFWOQLZ3YDPOD5AVCNFSM6AAAAAA6HZNZSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBSGUZTQOJXGU . You are receiving this because you were mentioned.Message ID: @.***>

rvita commented 7 months ago

regarding: do you consider Column O to be complete for IEDB? If so do you want to check the above box in the list. As of now column O is up to date, but this is something we are always working on expanding and more ontologies will be added over time. I donot know what you mean by "check the above box in the list." - maybe someone else already checked that box for me?

bcorrie commented 7 months ago

@rvita yes, the box is checked... 8-)

As of now column O is up to date, but this is something we are always working on expanding and more ontologies will be added over time. I donot know what you mean by "check the above box in the list." - maybe someone else already checked that box for me?

Thanks, that is what I thought, and yes someone checked the box - so we are done 8-)

bcorrie commented 7 months ago

OK, looks like the ontology inventory is done, I closing this issue.