airsdk / Adobe-Runtime-Support

Report, track and discuss issues in Adobe AIR. Monitored by Adobe - and HARMAN - and maintained by the AIR community.
201 stars 11 forks source link

Log and Ignore invalid SWFs file to be stripped #3247

Open marcussacana opened 4 months ago

marcussacana commented 4 months ago

Currently the ADT crashes when a invalid swf is in the list to be stripped, the problem is the error message does not show what is the bad file in the list.

A error message of invalid swf look like this:

java.lang.NegativeArraySizeException: -872726369
        at com.adobe.air.ipa.SWFUtils.read(SWFUtils.java)
        at com.adobe.air.ipa.SWFUtils.inspect(SWFUtils.java)
        at com.adobe.air.ipa.SWFUtils.<init>(SWFUtils.java)
        at com.adobe.air.ipa.SWFSplitter.main(SWFSplitter.java)
Exception in thread "main" com.adobe.air.InvalidInputException: Invalid input. Not a valid swf file
        at com.adobe.air.ipa.SWFSplitter.main(SWFSplitter.java)
Compilation failed while executing : ADT

Since I have more than 6000 files to be stripped will not be an easy task run each time looking for the bad ones. I hope there are a optional argument for ignore the invalid swfs, and as well change the error message to log what is the bad swf file.

ajwfrost commented 4 months ago

We'd recently added a bit more information/logging for this area I believe (but not yet in a release) - I'll check whether it would hit the above condition and provide what you're after. Plus I would have thought we should be able to handle the different file separators (#3242) so we'll check that too....

thanks