search

airshipit / airshipctl

A CLI for managing declarative infrastructure.
Apache License 2.0
43 stars 49 forks source link

Replace hardcoded values in Ephemeral function with ReplacementTransformer Variable Catalogue #299

Closed jingvar closed 3 years ago

jingvar commented 4 years ago

Problem description (if applicable) We have hardcoded and dependent values in manifests and their scripts. Should use airshipctl's features to store site specific values in VariableCatalogue kind and render documents with ReplacementTransformer.

Proposed change Solve https://github.com/airshipit/airshipctl/issues/298 Refactoring manifests.

Potential impacts Potential security or performance related impacts.

airshipbot commented 4 years ago

Related Change #727095

Subject: [WIP] Replace hardcoded values in Ephemeral function with ReplacementTransformer Link: https://review.opendev.org/c/airship/airshipctl/+/727095 Status: ABANDONED Owner: Nikolay Fedorov (nfedorov@mirantis.com)

Approvals

Code-Review
! None
Verified
-1 Zuul
Workflow
! None

Last Updated: 2021-03-19 12:39:27 CDT

Issue reopened due to new activity on Gerrit.

jezogwza commented 4 years ago

Need to discuss this on the YAML Call. There is potential overlap with some of this information might belong on other more generic catalogues. i.e. Versions of Kubelet, Calico etc . Moving to the v2 Milestone.

eak13 commented 3 years ago

@mattmceuen has this been resolved with the catalog work done to date, or should it remain open?

jingvar commented 3 years ago

As I see, we still have hardcoded certificates.

michaelfix commented 3 years ago

@mattmceuen - can we confirm if this can be closed?

mattmceuen commented 3 years ago

@mf4716 @ak3216 I think this can be closed. Any additional ephemeral bits that may need cataloguing should be handled via a more targeted work when they're found.

eak13 commented 3 years ago

Closing

eak13 commented 3 years ago

Closing due to being reopened by abandoned patchset