airshipit / airshipctl

A CLI for managing declarative infrastructure.
Apache License 2.0
43 stars 49 forks source link

Integrate clusterctl rollout into airshipctl #433

Open lb4368 opened 3 years ago

lb4368 commented 3 years ago

Proposed change Integrate airshipctl with clusterctl rollout so that we can take advantage of the feature to rollout updates to the cluster currently being managed by airshipctl.

clusterctl rollout

Integrate with airshipctl cluster rollout

lb4368 commented 3 years ago

@Arvinderpal - I believe you were going to take this one

Arvinderpal commented 3 years ago

Yes, please assign it to me.

Arvinderpal commented 3 years ago

Update: With v0.4.0, the rollout command is part of clusterctl. There are a couple of sub-commands, namely status and history that still need to be implemented. They are dependent https://github.com/kubernetes-sigs/cluster-api/issues/3486 which I'm also working on. Progress has been slow due to a lack of reviewers within the CAPI community.

Also, in airship, we have recently switched to using clusterctl as a binary (via KRM funcs). In the original model, clusterctl was consumed as a library and therefore to use these new commands, some level of code integration was needed. We may need to reassess how best to incorporate these commands.