airshipit / airshipctl

A CLI for managing declarative infrastructure.
Apache License 2.0
43 stars 49 forks source link

Redesign `airship cluster status` command #491

Open lb4368 opened 3 years ago

lb4368 commented 3 years ago

Problem description The current airshipctl cluster status command needs to be redesigned for the current architecture of airshipctl taking into account phases and multiple clusters.

Proposed change Need to revisit the airshipctl cluster status command design to determine it use in the current airshipctl architecture.

uberscott commented 3 years ago

@lb4368 I can take on this issue, although I may need a deeper explain of what is going on and how to fix.

kozhukalov commented 3 years ago

It seems barely possible to implement this at the moment. Airship phase engine is stateless, we don't use any operator to deal with phases/phase plans. We don't deploy phase CRs anywhere. We also don't store phase run results/errors anywhere. A user who runs a phase plan can see which of the phases were successful and thus cluster status. But we can not have a separate command to gather the cluster status since we don't have such a place from where the status could be collected.

So, my suggestion is to close the issue as not feasible until we are going to use a stateful phase running mechanism.

eak13 commented 3 years ago

@kozhukalov I'll add this to the design call agenda for Thursday 7/8 & we can discuss the path forward for this issue. Thanks for identifying the challenges.