Several test sites in airshipctl manifests are outdated

raliev12 commented 3 years ago

Describe the bug We have several test sites in airshipctl manifests, but we have only one which configured and tested properly - test-site. Another ones, az-test-site, docker-test-site, gcp-test-site and openstack-test-site are outdated, we don't test them properly against our CI, we don't deploy them and they have misconfigured phase plans. The quick static validation of those test sites shows a lot of problems, like

improperly configured cluster-move phase without namespace
lack of cert-manager CRDs on cluster before running clusterctl-init-phase (which uses them) and so on.

Those sites require a lot of changes, fixes and adjustments to make them properly work.
Proposed solution:

[x] Temporary disable mentioned test sites out of validate-site-docs job support since we can't maintain the same quality standards for test-site and another ones;
[ ] Once static validation based on kubeval embedded into validate-site-docs job, gradually enable az-test-site, docker-test-site, gcp-test-site and openstack-test-site back to validation support again. It might be helpful also to run check experimental zuul job with config file of appropriate site within appropriate patchsets to make sure it does work properly.

Steps To Reproduce Deploy or validate of one the following test sites:

az
docker
gcp
openstack

Expected behavior No issues during validation and deployment of the mentioned test sites.

airshipbot commented 3 years ago

Related Change #780681

Subject: Add validation phases Link: https://review.opendev.org/c/airship/airshipctl/+/780681 Status: MERGED Owner: Ruslan Aliev (raliev@mirantis.com)

Approvals

Code-Review
+2 Matt McEuen
+2 Kostyantyn Kalynovskyi
Verified
-1 ATT Airship2.0 CI
+2 Zuul
Workflow
+1 Kostyantyn Kalynovskyi

Last Updated: 2021-04-27 22:39:01 CDT

rkjain commented 3 years ago

I can may be help test this out with docker and gcp

eak13 commented 3 years ago

@uberscott do you want to give this issue a shot? Thanks.

uberscott commented 3 years ago

@ak3216 SURE! give it to me. Thank you!

eak13 commented 3 years ago

@uberscott all yours! Thanks!

sshiba commented 3 years ago

I have update the scripts for az-test-site but cannot run gating in Zuul. See https://review.opendev.org/c/airship/airshipctl/+/787648.

Had plenty of time in between trying to deploy baremetal target cluster for testing Dex, so use the waiting time to multi-task.

Instead, I have updated the scripts to run in an "automated" fashion so the validate the deployment. In the past we have created Jenkins pipeline for az-test-site, where Azure subscription credentials were save in Jenkins secrets.

sshiba commented 3 years ago

The scripts used to deploy az-test-site have been updated and validated through executing the scripts on a clean validation VM instantiated on Azure cloud. https://review.opendev.org/c/airship/airshipctl/+/787648

Jenkins CI Pipeline for az-test-site deployment, which is used to automate the deployment of Target cluster on Azure cloud. This pipeline uses the updated scripts in the above patchset. https://review.gerrithub.io/c/att-comdev/cicd/+/515769

airshipbot commented 3 years ago

Related Change #789640

Subject: Update Validation Logic for Clusterctl Move Link: https://review.opendev.org/c/airship/airshipctl/+/789640 Status: MERGED Owner: Ratnopam Chakrabarti (ratnopam.chakrabarti@ericsson.com)

Approvals

Code-Review
+2 Kostyantyn Kalynovskyi
+2 Drew Walters
+1 Bijaya Sharma
+1 Matthew Fuller
+1 Deepak Kataria
Verified
-1 ATT Airship2.0 CI
+2 Zuul
Workflow
+1 Drew Walters

Last Updated: 2021-05-25 23:19:01 CDT

airshipbot commented 3 years ago

Related Change #790896

Subject: Update provider manifests for site validation Link: https://review.opendev.org/c/airship/airshipctl/+/790896 Status: NEW Owner: Ratnopam Chakrabarti (ratnopam.chakrabarti@ericsson.com)

Approvals

Code-Review
! None
Verified
+1 Zuul
+1 ATT Airship2.0 CI
Workflow
! None

Last Updated: 2021-05-26 13:38:59 CDT

jezogwza commented 3 years ago

We need to focus on docker and azure.

airshipit / airshipctl