search

airshipit / airshipctl

A CLI for managing declarative infrastructure.
Apache License 2.0
43 stars 49 forks source link

Implement `airshipctl version` #630

Closed ian-howell closed 2 years ago

ian-howell commented 3 years ago

Problem description (if applicable) airshipctl version currently reports that it is v0.1.0, no matter when or how the binary was created.

Proposed change Borrow from a more mature project such as helm or kustomize so that we can display the tag or git sha of the built binary.

ian-howell commented 3 years ago

Here's what I was talking about with linker flags on the Flight Plan call: https://www.digitalocean.com/community/tutorials/using-ldflags-to-set-version-information-for-go-applications

sreejithpunnapuzha commented 2 years ago

Commit https://review.opendev.org/c/airship/airshipctl/+/810128 Pushed with the changes.

sreejithpunnapuzha commented 2 years ago

Commit https://review.opendev.org/c/airship/airshipctl/+/810128 is merged. hence closing this issue.