Closed seaneagan closed 3 years ago
SIP currently labels scheduled BMHs with:
sip.airshipit.org/cluster: <SIPCluster namespace>_<SIPCluster name>
It seems beneficial to split this label into :
sip.airshipit.org/cluster-namespace: <SIPCluster namespace> sip.airshpiit.org/cluster-name: <SIPCluster name>
Reasons: 1) more self-documenting 2) less likely to run into label name character limits (63 chars) 3) matches common practice in other projects e.g. Vino 4) allows label selection by namespace/name individually (for scripts, debugging, etc)
Metal3 does support consuming BMHs via multiple label selectors: https://github.com/metal3-io/cluster-api-provider-metal3/blob/master/docs/api.md#hostselector-examples
https://review.opendev.org/c/airship/sip/+/783962
seaneagan
commented
3 years ago
SIP currently labels scheduled BMHs with:
It seems beneficial to split this label into :
Reasons: 1) more self-documenting 2) less likely to run into label name character limits (63 chars) 3) matches common practice in other projects e.g. Vino 4) allows label selection by namespace/name individually (for scripts, debugging, etc)
Metal3 does support consuming BMHs via multiple label selectors: https://github.com/metal3-io/cluster-api-provider-metal3/blob/master/docs/api.md#hostselector-examples