airshipit / sip

4 stars 1 forks source link

Remove extra nodePort field from loadBalancerWorker config #21

Closed seaneagan closed 3 years ago

seaneagan commented 3 years ago

Problem description (if applicable) As noted in https://review.opendev.org/c/airship/sip/+/786306 for the loadBalancerWorker service the nodePort field is now ignored, since nodePortRange field is used instead. The nodePort field is inherited from the base service type. We need to refactor the types to remove this.

Proposed change Remove nodePort from the base service type, and include it only for the services that need it.