airshipit / treasuremap

Reference Airship manifests, CICD, and reference architecture.
http://openstack.org
Apache License 2.0
52 stars 39 forks source link

Add Dex for Sub-Cluster Authentication #134

Closed lb4368 closed 3 years ago

lb4368 commented 3 years ago

Problem description Need to provide a Dex OIDC provider pod during a sub-cluster deployment in order to be able to configure authentication and authorization within each sub-cluster.

Previous design had the SIP operator delivering Dex as a infrastructure service as a SIP CR was applied. Since Dex deployment does not rely on any of SIP scheduling results and can leverage manifest functions defined for delivering Dex for the target cluster, it may be simpler to deliver Dex per sub-cluster directly via manifests during the same phase that the SIP CR is delivered for providing sub-cluster infrastructure. This also decouples Dex as the authentication provider for the sub-clusters.

Proposed change Leverage manifest functions created as part of #19 to deliver a Dex service to the target cluster on a specified NodePort as part of each sub-cluster deployment.

The deployment of Dex will need to allow for specifying configuration of Dex for the associated sub-cluster including:

SaurabhArora86 commented 3 years ago

Please assign it to me, I can take it up.

SaurabhArora86 commented 3 years ago

Based on discussion, have created patchset https://review.opendev.org/c/airship/treasuremap/+/790420

SaurabhArora86 commented 3 years ago

Patchset for Dex replica https://review.opendev.org/c/airship/treasuremap/+/790964

SaurabhArora86 commented 3 years ago

As per discussion, since we don't need to change replica for dex necessarily and in case it is required, it could be handled via kustomize patch. Abandoned the patchset for replica changes https://review.opendev.org/c/airship/treasuremap/+/790964

For subcluster related changes, updated the patchset https://review.opendev.org/c/airship/treasuremap/+/790420/ and would create a different patchset for dex function related changes which is WIP

SaurabhArora86 commented 3 years ago

Based on review comments, below patchsets are ready for view https://review.opendev.org/c/airship/airshipctl/+/792316 https://review.opendev.org/c/airship/treasuremap/+/791931 Note: https://review.opendev.org/c/airship/treasuremap/+/791931 depends on https://review.opendev.org/c/airship/airshipctl/+/792316 to work

SaurabhArora86 commented 3 years ago

Patchset https://review.opendev.org/c/airship/treasuremap/+/790420 has all treasuremap changes for Dex for sub-cluster.

SaurabhArora86 commented 3 years ago

All the below patchsets belonging to this US is merged. https://review.opendev.org/c/airship/treasuremap/+/790420 https://review.opendev.org/c/airship/airshipctl/+/792316 https://review.opendev.org/c/airship/treasuremap/+/791931

eak13 commented 3 years ago

Closing per above patchset merges