airshipit / treasuremap

Reference Airship manifests, CICD, and reference architecture.
http://openstack.org
Apache License 2.0
52 stars 39 forks source link

Create delivery mechanism for sub-cluster QCOW images #169

Closed eak13 closed 3 years ago

eak13 commented 3 years ago

Building on the work done for delivering the baremetal QCOW image, develop a similar mechanism to deliver sub-cluster VM QCOW images. This should be implemented for the multi-tenant site type & included in the sub-cluster deployment in STL3.

Reference the following merged patchsets: https://review.opendev.org/c/airship/airshipctl/+/776705 < Defines delivery mechanism of the qcow image via Ironic. Includes variable catalog updates to reference the qcow image. There are some other updates that removes pre-kubeadm commands that are now contained in the image and others that will likely not be needed for resolving this issue for sub-clusters. https://review.opendev.org/c/airship/airshipctl/+/779032 < Adds qcow image references & replacements to versions catalog

The sub-cluster image bundle will be defined in this issue: https://github.com/airshipit/images/issues/20

aostapenko commented 3 years ago

https://review.opendev.org/c/airship/airshipctl/+/796484

eak13 commented 3 years ago

@aostapenko the above patchset creates the function in airshipctl. Will there also be a PS to include it for use by the multi-tenant type in treasuremap? Sorry if I'm jumping the gun & it's in progress. Thanks.

aostapenko commented 3 years ago

I think we can leave cosmetic changes for later. And we'll need to have more discussion on desired layout given specifics of situation we're in.

michaelfix commented 3 years ago

@aostapenko , it would be a big help to include the Relates-To tag, or Closes tag, in the commit message of your PSs. This helps us track and correlate the issues-to-PSs. And, if the Closes tag is used, a bot will automatically close the respective GitHub issue. Thanks. https://github.com/airshipit/airshipctl/blob/master/CONTRIBUTING.md#submitting-changes

michaelfix commented 3 years ago

Abandoned: https://review.opendev.org/c/airship/airshipctl/+/796484 Replaced by: https://review.opendev.org/c/airship/treasuremap/+/796992

Per Andrii, TM169 can be closed as 796992 merged early morning hrs of 23 June 2021.

eak13 commented 3 years ago

Closing per code merge.